Kouhei Ueno comments

Repositories
Issues
Comments

Results 4 comments of


                                            Kouhei Ueno

Avoid heavy IO within CachedBlobEntriesManager: DropCacheEntry and closeOldCacheEntriesIfNeeded

Maybe closeOldCacheEntriesIfNeeded writeback case is unavoidable? The CacheSyncer already must be under heavy load in those cases.

cachedblobstore: Stale writeback may fail to query version

Labeling as P2, as it shouldn't cause any real issue. Next Sync() should succeed fine.

Sugary defaults: can we create a simple case for advanced ahead-of-time tools?

I'm not against adding this, but I strongly prefer to not have this in the first cut. I think we can carefully add this later.

Don't cache HTTP errors in the module map

I'm generally supportive of the proposal. I think this change would steer the module fetching behavior more toward availability (vs determinism which was prioritized when the feature was originally designed),...