Neil MacDougall

Results 224 comments of Neil MacDougall

We should re-validate that this is still an issue - I believe this is down to a change in base image which does not contain `sh` - I think this...

automated e2e tests added with this PR: https://github.com/rancher/dashboard/pull/10745

@jakefhyde FYI, UI work has been done and merged for this feature. Covered by unit tests. Assuming feature e2e testing will be done by backend QA.

@gaktive I don't think we allow the underscore because Rancher uses that name to name the cluster resource - this is a k8s object and I don't believe `_` is...

@cpinjani Does this work with 2.8? (We migrated the UI from the old Ember to Vue in 2.9, so want to check if this is a side-effect of that).

@cpinjani Thank you @gaktive I am going to remove the `release-blocker` label - since this is not a regression, this is a not a release blocker.

Suggest we add: `ui-banner-header`, `ui-banner-footer` and `ui-banner-login-consent` The UI will use these if they are defined, otherwise it will continue to use the single banner setting. This allows someone to...

This will require a small backend change to allow the new individual settings to be retrievable by an unauthenticated user.

Created backend issue https://github.com/rancher/rancher/issues/44439

PR for backend changed: https://github.com/rancher/rancher/pull/45528