vk_video_samples icon indicating copy to clipboard operation
vk_video_samples copied to clipboard

AV1 decode: fix reference frame order hint array

Open fhvwy opened this issue 10 months ago • 1 comments

The code here is intended to implement this logic from the AV1 specification section 5.9.2:

for ( i = 0; i < REFS_PER_FRAME; i++ ) {
    refFrame = LAST_FRAME + i
    hint = RefOrderHint[ ref_frame_idx[ i ] ]
    OrderHints[ refFrame ] = hint
}

Fix the indexing so that the OrderHints array is set exactly as the specification states rather than offset by one element. (The offset was propagating into incorrect values for the SavedOrderHints element for reference frames.)

fhvwy avatar Apr 07 '24 13:04 fhvwy

Thank you, Mark! We agree with your findings and will be working on fixing this in the CTS and the drivers before fixing the sample app.

zlatinski avatar Apr 12 '24 20:04 zlatinski