vk_video_samples icon indicating copy to clipboard operation
vk_video_samples copied to clipboard

Published 20 hours ago • verified publisher icon nvpro-samples

10-bit presentation looks wrong on radv

Open airlied opened this issue 1 year ago • 4 comments

I'm seeing what looks like maybe 8-bit sampling from 10-bit data or something when testing HEVC 10-bit content.

Does it work okay on nvidia?

airlied avatar May 30 '23 06:05 airlied

I wonder is this because I'm just running in an 24-bit X server

airlied avatar May 30 '23 06:05 airlied

I just tried a depth 30 X session, but still seeing a red tint over the whole video.

airlied avatar May 30 '23 06:05 airlied

okay this looks like radv doesn't offer ycbcr sampling on the format, I should probably investigate fixing that first.

airlied avatar May 30 '23 06:05 airlied

Hi Dave,

Please also check the m_samplerYcbcrModelConversion and m_samplerYcbcrRange in VulkanFrame<FrameDataType>::DrawFrame(). Currently, the app has it fixed to BT709 NARROW range, but this should reflect the settings from the compressed content. Most of the 10/12-bit content uses BT2020 with full range. So, your colors can look off. I'll fix the app to handle this correctly, soon.

zlatinski avatar Mar 28 '24 22:03 zlatinski