Nathan Voxland

Results 104 comments of Nathan Voxland

Sorry for the slow response. I keep feeling like some of the larger test refatoring was coming soon but then we keep finding other things to work on first... Since...

True, @schrieveslaach . I had noticed that but forgot to include it in my notes. I updated them with that added. Thanks

What version of Liquibase are you seeing the issue in currently? We've put some changes in ones since the originally reported 4.3.5 that should improve it.

I'm thinking the format for this should be a bit different. The "tag" command is just one example of other "higher level" sql changes and/or non-sql commands that would be...

The fix in this pull request definitely works fine, but I am concerned with how broad the change is. There can more more uses for sqlVisitor than just modifySql, and...

On further review, I decided this approach isn't going to work. I agree that modifySql/append is a bit of blunt instrument, but it's also doing what it says it does...

Changing it from a global scope to a thread scope would impact people using the threads differently. We have that SingletonScopeManager named as such under the plan to eventually make...

I see what you are getting at. I think it helps to remember that even though there is a tagDatabase function that can be used in a changelog, it's not...

We need the changelog file, though, because that has the actual logic of what to roll back and how. The history table doesn't include enough to actually do the roll...

This has possibly been fixed by other changes, but I'm not able to reproduce the problem even on the listed 4.6.2 version. Can you create a sample project I can...