Nathan Voxland

Results 104 comments of Nathan Voxland

You can have as many modifySql tags as you'd like. And within each you can have as many append/prepend/replace/regExpReplace tags as you need in there. It's generally most readable to...

The uppercase-ness comes from how h2 stored case-insensitive/unquoted object names. It happens to store them uppercase, and then anytime you reference something as just `user` it uppercases it and then...

Yes, avoiding potential keywords for object names like "additional_value" vs. "value" is always the best approach. Especially when you're dealing with multiple database types. Also remember, there is always and...

We should re-look into the best list of reserved words for h2, possibly divided by version since they have changed them significantly between 1.x and 2.x. For the times you...

This is handling the case where someone has a changelog with: ``` ``` which is a different way of tagging the database than with `liquibase tag my_tag` The difference in...

This falls into a whole rabbit hole of "there are lots of database-specific features for every database, and it's hard for snapshot to handle them all". It's worth looking at...

I think the test seems good. It does spin up another process which is heavyweight, but because we use singletons etc. within the JVM, just using another thread wouldn't **really**...

Looking at your `changeLogService.reset();` call you added, though, if it is something you were seeing problems caused by the temporary unlock in HubUpdater, my worry is that just handling it...

@schrieveslaach lockService.reset() is a similar reset but for the LockService. What should generally be happening is that we use the lock to ensure that your instance is the only one...

Thanks for the update @schrieveslaach. I'm trying out some options for improving testing in general around the lock service and then fixing a variety of bugs based on what those...