Nicolas comments

Results 9 comments of


                                            Nicolas

Led roulette blocks execution when using STM32F3348-DISCO

Great, I'll do that! Thanks

[SQLair] Replace slice queries in domain/externalcontroller/state

@Aflynn50 I think @SimonRichardson was referring to the QA steps in https://github.com/juju/juju/pull/15940, although these won't help much because this domain is not yet fully wired up. Worth playing with that...

Reload spaces from the bootstrap worker instead of agent bootstrap

/build

first draft of general tests

I completely agree with you, when adding new dimensions its very easy to get tempted with copy/pasting tests. This should improve our code quality a lot

implement unimplemented functions & make new types

Hi, I think I could help. I'll start with the electro ones...

refactor(facade): use model config service in provisioner facade

This facade is used in the `containerbroker` and `provisioner` (container init) workers. I'd QA it by adding some container machines and deploying into it, something like: ``` juju add-machine lxd...

feat: juju switch to previous controller or model

You will also need to regenerate some mocks (see the `Generate` check job): ``` go generate ./cmd/juju/commands/... go generate ./cmd/juju/user/... ```

[juju 4] vSphere cloud doesn't start machines

fixed by https://github.com/juju/juju/pull/21469

[juju4] failed to acquire node: No available machine

Just for some context, the `storage=root:0,4:1,5:1,6:1,7:1` constraint added is juju 4 specific. Deploying postgres (16/edge) with juju 3.6 works well in the same cloud: ``` ubuntu@maastiff:~$ juju status Model Controller...