Vincent Driessen

Results 66 issues of Vincent Driessen

These helpers are "somewhat" typed out, but there still is a lot of manual type casting going on in there, which is a smell. Since this is such an important...

internal

Rather than having tests live "among" source files, like: I'd propose to move these to the following structure: (Here, the helper file `test/utils.ts` is moved to `src/__tests__/_helpers.ts`.) Moving unit tests...

internal

The "doc" is an old abstraction. Rename and refactor this to be a bit to simplify internals.

internal

In https://liveblocks.slack.com/archives/C02PZL7QAAW/p1653567099526459, we talked about how we might be able to get rid of the LiveRegister class. This would be awesome, because it would nihilate the difference between LiveStructure and...

internal
packages

Get rid of the abstract base class and stop using inheritance in favor of using a tagged union. This will simplify the code by making it more readable for newcomers,...

internal
packages

These checks would have to be: - 100% automatic (we shouldn't be manually writing these – we already wrote this in TypeScript) - injected only for _public_ APIs, right in...

enhancement

See https://github.com/liveblocks/liveblocks/pull/337#discussion_r897511528 for context.

breaking change

This simplifies the API for the `getOthers()` call to not return a custom array proxy, but a real array. This was attempted to be merged in #109 and #122, but...

needs discussion
idea