Vincent Driessen

Results 69 comments of Vincent Driessen

To generalize the example a bit: { foo: x | y | null, // will correctly be marked optional bar: x | y | void, // won't be marked optional,...

Thanks for the quick fix, @brigand – really appreciated! After reading the patch I was convinced it would work, and it does… as long as we use the union syntax...

I ran this locally to try it out, but I end up with a directory filled with "empty" man pages inside the repo. They all contain this content: ``` .\"...

OK, I guess it's not that big of a deal to support, and you're right: this can grow organically and start sourcing from a dedicated `MANUAL.md` eventually. I do however...

Hi @mmatrosov — thanks so much for this contribution! I finally took a chance to look at this and use it directly myself. I like the general trick on this...

(I tried adding that commit to this PR, but it looks like you'll have to [give me permissions](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests) to do so.)

> Hm, that's weird. I have and I had the "Allow edits by maintainers" option enabled for this PR. Well, anyway, if you have trouble adding commits to the PR,...

I'm open to suggestions here, but I don't think Git offers a reliable way of looking up the main branch name. If there is a reliable way to do that,...

Hey Tom, I think this could work, but it would have to be added to all the scripts consistently if this is the road to go down to, see https://github.com/nvie/git-toolbelt/search?q=main-branch....

Thank you, @ernstki! You make an _excellent_ point here, and one that I hadn't really considered like this before. But you're absolutely right, and I would love to change the...