Nicolás Venturo
Nicolás Venturo
The cache currently uses hardcoded ids - it'd be good if we could pass ids on construction, to be stored as immutable state variables, and use those instead. This would...
Before joins, exits, add/remove, etc., or in general any operation that either affects the supply or reads it, we should pay due external fees (protocol + manager).
In ComposableStablePool we simply used the versions that receive arrays and zeroed out most of the inputs, but here we won't have all balances. These functions don't actually care about...
This will include the virtual supply from #1810 and the unpaid AUM fees (https://github.com/balancer-labs/balancer-v2-monorepo/pull/1800 removed external swap fees).
Some actions (such as killing gauges) don't emit events - it'd be useful to get the Adaptor to emit events with target and data when triggered. This can of course...
We currently always round down when upscaling, but this is not necessarily correct. See [this comment](https://github.com/balancer-labs/balancer-v2-monorepo/pull/1738#discussion_r969679780): >I don't quite remember the reasoning behind this, but it was likely related to...
This is a simple change so we can e.g. extract the artifacts for a pool in a deployment of its factory. I had to change one of the internal functions...
The current API only provides access via `.length()` and `.at()`. It'd be great to have a `.list(start, end)` that returned a _partial_ view of the set's elements. The reasoning behind...
We want to migrate our boost contract (`PreseededVotingEscrowDelegation`) to the new [`BoostV2`](https://github.com/curvefi/curve-veBoost/blob/master/contracts/BoostV2.vy) contract developed by Curve. It is not fully compatible with the old one, but that is ok: the...
After we've completed #2397 and have used that for a while.