Nicolás Venturo
Nicolás Venturo
We don't quite know what values might be good max values for e.g. AUM fees. Perhaps we could not have limits at all and leave that up to the controller.
Similar to #1139, we could write a simple contract that checks that any token added to a gauge has been first added to a list of pre-approved tokens. This prevents...
We've been discussing [here](https://github.com/balancer-labs/balancer-v2-monorepo/pull/982#discussion_r742170807) how to handle token approvals when the relayer is the sender of the tokens. We could simply always grant allowance when the relayer is the sender,...
https://github.com/balancer-labs/balancer-v2-monorepo/pull/989 included the `AaveWrapping` module, but we don't yet have tests for it. We can use `LidoWrapping` tests as a foundation for these.
As mentioned [in this review comment](https://github.com/balancer-labs/balancer-v2-monorepo/pull/982#discussion_r742150652), now that we allow for the relayer to be the sender of swaps, joins, etc., we should have simple tests that check that this...
We've made a number of changes and are planning to have even more. Once they are all done, it'd be good to asses whether we want to release a new...
We've identified scenarios where there are valid 'given out' actions while some leftover (e.g. unstake + exit given tokens out, resulting in dust BPT). We could provide a escape hatch...
The current implementation of the relayer returns the return values of all delegatecalls it makes. This can be useful, though I don't think we care about it in most cases....
While MetaStable and Linear Pools have this, we did not add it for the PremintedMetaStablePool as that one features more tokens (up to 5), and support for array-like `immutable` state...
https://github.com/balancer-labs/balancer-core-v2/pull/568 introduced Asset Managers to the `BasePool`, along with the `setAssetManagerPoolConfig` function, but didn't add any tests for it. We should have basic tests that check that this function calls...