nusmods

nusmods copied to clipboard

Optimize Venues search using React Concurrent Mode APIs

6

### TL;DR Uses React Concurrent Mode APIs (added in #3039) to optimize the Venues components reworked in #3038. ### Optimizations in this PR 1. Uses `useDeferredValue` to allow the search...

taneliang

Overhaul Venues components

4

## Context This is a rather large PR that makes various changes to the components on the Venues page. ## Details The biggest (and probably only?) user-facing change is that...

taneliang

Adopt React concurrent mode

7

## Context This is another item split out of #2922. This PR: * Installs experimental versions of React and React DOM. * Switches the whole app to use concurrent mode....

taneliang

This package was renamed, and so will not be automatically upgraded by Renovate bot. See: https://github.com/atomiks/tippyjs-react/releases/tag/v4.0.0 This new package also comes with breaking changes. The biggest one seems to be...

taneliang

Fix noob React Testing Library mistakes from #3007

4

I added React Testing Library in https://github.com/nusmodifications/nusmods/pull/3007, but as it was the first time I used it I made some [common mistakes](https://kentcdodds.com/blog/common-mistakes-with-react-testing-library) 😅 I only found out about them when...

taneliang

### Describe the bug A clear and concise description of what the bug is. ### To Reproduce Steps to reproduce the behavior: 1. Start NUSMods locally (you can't use nusmods.com...

taneliang

[React Testing Library](https://testing-library.com/docs/react-testing-library/intro/) was added in #3007 so that it's easier to test components in context and from a user's perspective. It also feels like a much nicer API. To...

taneliang

Save e-learning venues as E-Learning in scraper

2

Follow up of https://github.com/nusmodifications/nusmods/pull/2736. This PR changes the scraper to save lesson venues as "E-Learning" when the API returns a `room` of `E-Learn_*` for lessons. To see current shaped of...

chrisgzf

Use Webpack 4 chunk prefetch to improve performance

6

Since we've upgraded to Webpack 4, we can take advantage of Webpack 4's [chunk prefetch/preload feature](https://webpack.js.org/guides/code-splitting/#prefetching-preloading-modules) to improve our performance. Documentation: https://webpack.js.org/guides/code-splitting/#prefetching-preloading-modules Search for `\bimport\(` to find places where we...

ZhangYiJiang

## Context TL;DR we remove react-loadable and React Router and replace them with a DIY solution with Suspense and Relay-like Entry Points (or at least my understanding of entry points)....

taneliang