nusmods icon indicating copy to clipboard operation
nusmods copied to clipboard

Save e-learning venues as E-Learning in scraper

Open chrisgzf opened this issue 5 years ago β€’ 2 comments

Follow up of https://github.com/nusmodifications/nusmods/pull/2736.

This PR changes the scraper to save lesson venues as "E-Learning" when the API returns a room of E-Learn_* for lessons.

To see current shaped of our scraped data: https://nusmods.com/api/v2/2020-2021/modules/CS1010.json

@ZhangYiJiang does this look right to you? Also would need some help to test this, if possible. πŸ˜…

Also, don't merge this yet. Still need to add the frontend changes.

chrisgzf avatar Aug 16 '20 16:08 chrisgzf

Codecov Report

Merging #2823 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2823   +/-   ##
=======================================
  Coverage   46.34%   46.34%           
=======================================
  Files         250      250           
  Lines        5302     5302           
  Branches     1220     1220           
=======================================
  Hits         2457     2457           
  Misses       2845     2845           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 6da0ef1...b0514b1. Read the comment docs.

codecov[bot] avatar Aug 16 '20 16:08 codecov[bot]