Bryan Tong

Results 55 comments of Bryan Tong

Whenever you get a chance, I am hopeful we packaged in some fixes.

I spent time making sure this would be the least impactful fix to the problem. @ljharb any help here?

This security issue remains despite the approval for changes. Any way this can be merged? @garyyeap @ljharb @jacksctsai @ben-lin ?

My apologies, Ill leave you out of it. Initially I saw you on the Organization and thought that you may be able to contact someone with publishing privileges. Its a...

Hows the community support of the new socket.io? I know its a major overhaul.

You should be using app.io.broadcast. This follows the same paradigm as socket io I believe. You cannot broadcast from the contextual socket it must be done with the main socket...

Because a request comes from the client emitting an event so the only thing you can really do is respond which matches the Socket.io documentation. To emit an event back...

No problem. I went through the same logic process as you did so figured I would help.

There are too many changes within this one request, would it be possible to break this up into 3 separate requests. * Keep this request as the Test Addition *...

> Sorry, I can't keep such phpdocs untouched. ;-) > > Yes I can revert the code changes and keep the tests classes. Its no problem at all, I am...