lib-array2xml icon indicating copy to clipboard operation
lib-array2xml copied to clipboard

Published 20 hours ago • verified publisher icon nullivex

add simple tests

Open voku opened this issue 5 years ago • 3 comments

This change is Reviewable

voku avatar Feb 20 '20 00:02 voku

There are too many changes within this one request, would it be possible to break this up into 3 separate requests.

  • Keep this request as the Test Addition
  • Add a new request to fix the license, but keep the COPYING and COPYING.LESSER for now.
  • Finally, a third request to add the PHP Code Sniffer configuration.

I love the idea of adding testing to this class so I am thrilled to get these changes merged and of course get a new version released. My concern is making it clear what happened.

Please let me know if this is achievable.

nullivex avatar Feb 20 '20 00:02 nullivex

Sorry, I can't keep such phpdocs untouched. ;-)

Yes I can revert the code changes and keep the test classes.

voku avatar Feb 20 '20 01:02 voku

Sorry, I can't keep such phpdocs untouched. ;-)

Yes I can revert the code changes and keep the tests classes.

Its no problem at all, I am really glad to see some progress on this package! Provided you can make these changes, I will get this pushed through as soon as I can finish reading the reviews.

nullivex avatar Feb 20 '20 01:02 nullivex