Nicholas Tolley

Results 103 comments of Nicholas Tolley

Apologies @hollandjg testing this script got lost on my to-do list after the holiday break @dylansdaniels can we sit together to test out this script on your windows machine?

@rythorpe apologies Dylan and I sat down several times to hammer out installation instructions but got distracted with formatting screenshots for the installation webpage. @dylansdaniels is it possible for you...

@jasmainak @rythorpe perhaps it'd be a good idea to make this a separate file? If we can find a solution to updating the section colors very rapidly, we can even...

Dropping this here for easy testing once we get closer to merging. I think rendering movies is going to be a longish wait for larger networks, but not absurdly so...

@rythorpe @jasmainak this PR is ready for review! Two weird errors have come up however. First it seems like sphinx-gallery doesn't support python versions older than 3.8 ![image](https://github.com/jonescompneurolab/hnn-core/assets/55253912/3e2f5400-ccab-480a-a1f6-a053e9b352df) Does this...

Yup just confirmed, sphinx now requires python>=3.8 https://github.com/sphinx-gallery/sphinx-gallery/blob/e2903c9e43572a0a29850f7ab153ff69098f5c81/setup.py#L58C5-L58C5

Ok updating the python version used for CircleCI worked, however it seems something in the MNE code is breaking the somato example now: ![image](https://github.com/jonescompneurolab/hnn-core/assets/55253912/e551a933-914a-4067-898f-3bf542df0678)

@rythorpe they are updated automatically! #433 fixed this early on, but then Rajat's project made a new and improved version where he implemented the Neuron functions for calculating end points...

@jasmainak this is ready for a final round of reviews when you have the chance! I think there are some tasks that might be delegated to followup PR's (e.g. a...

@chenghuzi I think a tonic drive is getting added that should be skipped: ![image](https://user-images.githubusercontent.com/55253912/232609948-60f8f253-9f1c-49d8-b8a5-82b91c0d06d6.png) Do you think you could follow the logic in #619 to filter out invalid tonic drives?...