[MRG] Add tonic inputs

[chenghuzi]

As titled.

[codecov-commenter]

Codecov Report

Merging #635 (a665a57) into master (cdd4050) will decrease coverage by 0.97%. The diff coverage is 67.61%.

:exclamation: Current head a665a57 differs from pull request most recent head effbdc1. Consider uploading reports for the commit effbdc1 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   92.19%   91.23%   -0.97%     
==========================================
  Files          22       22              
  Lines        4282     4426     +144     
==========================================
+ Hits         3948     4038      +90     
- Misses        334      388      +54     

Impacted Files	Coverage Δ
hnn_core/gui/gui.py	87.97% <33.84%> (-6.91%)	:arrow_down:
hnn_core/gui/_viz_manager.py	86.93% <64.86%> (-2.91%)	:arrow_down:
hnn_core/cell_response.py	86.87% <97.61%> (+2.34%)	:arrow_up:
hnn_core/cell.py	96.95% <100.00%> (ø)
hnn_core/params.py	91.92% <100.00%> (+0.03%)	:arrow_up:
hnn_core/viz.py	89.60% <100.00%> (+0.36%)	:arrow_up:

... and 1 file with indirect coverage changes

[ntolley]

@chenghuzi I think a tonic drive is getting added that should be skipped:

Do you think you could follow the logic in #619 to filter out invalid tonic drives? I think the culprit function is _extract_drive_specs_from_hnn_params()

[chenghuzi]

_extract_drive_specs_from_hnn_params

sure, but I guess it's _extract_bias_specs_from_hnn_params? Either way I'll check and let you know asap

[chenghuzi]

@chenghuzi I think a tonic drive is getting added that should be skipped:

Do you think you could follow the logic in #619 to filter out invalid tonic drives? I think the culprit function is _extract_drive_specs_from_hnn_params()

It should be fixed now. I didn’t open a new PR as it’s a minor modification, and adding just a filter condition in _extract_bias_specs_from_hnn_params seems to work.