Nikhil Kathole comments

Results 31 comments of


                                            Nikhil Kathole

Added support to read multiple accounts

> Hello @liangxiao1 , Thanks for commenting on the PR. > > I certainly agree with what you are saying here and also agree with the impact users have on...

As a new user, the example feature definitions file name in feast init is confusing

@MelissaFlinn ^

As a new user, the example feature definitions file name in feast init is confusing

There is also a good recommendation by @MelissaFlinn of adding a feastignore file in template (even if it just has a commented descriptive line in it).

fix(dask): Preserve remote URIs (e.g. s3://) in DaskOfflineStore path

Please sign the commit so that DCO commit pass

fix(dask): Preserve remote URIs (e.g. s3://) in DaskOfflineStore path

@predictorsSH There is 1 more instance in the same file where absolute path is not correctly set up https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/dask.py#L472 Can you please apply the same fix for `offline_write_batch` method ?

fix(dask): Preserve remote URIs (e.g. s3://) in DaskOfflineStore path

@predictorsSH can you please rebase (and squash, if possible) ? Once CI passed, we can get it merged.

ImportError: cannot import name 'runtime_version' from 'google.protobuf' in version 0.49.0

@Deshmukh1992 Can you please check if master branch fixes this issues for you ? It is fixed via https://github.com/feast-dev/feast/pull/5309 which will be available in upcoming release.

Error when trying to run feast with local provider and duckdb as offline store

@rsoaresp file_format needs to be defined explicitly, You can make sure to specify the file_format in FileSource like : ``` from feast.data_format import ParquetFormat driver_stats_source = FileSource( name="driver_hourly_stats_source", path="data/driver_stats.parquet", timestamp_field="event_timestamp",...

Update README.md

I think https://github.com/feast-dev/feast/pull/5063 PR that removed go-server docs suppose to revert which didn't happen cleanly @franciscojavierarceo

fix: Update minimum protobuf version to >=6.30.2

@misohu Thanks for the report and fix, please modify https://github.com/feast-dev/feast/blob/master/setup.py#L36 and run `make lock-python-dependencies-all` to compile the requirements.