fix(dask): Preserve remote URIs (e.g. s3://) in DaskOfflineStore path

Open predictorsSH opened this issue 9 months ago • 5 comments

… resolution

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Apr 02 '25 07:04 predictorsSH

Please sign the commit so that DCO commit pass

Apr 03 '25 04:04 ntkathole

@predictorsSH There is 1 more instance in the same file where absolute path is not correctly set up https://github.com/feast-dev/feast/blob/master/sdk/python/feast/infra/offline_stores/dask.py#L472 Can you please apply the same fix for offline_write_batch method ?

Apr 03 '25 10:04 ntkathole

Thanks! I've applied the same fix to offline_write_batch with the same logic.

Apr 03 '25 11:04 predictorsSH

@predictorsSH can you run the linter? make format-python?

Apr 04 '25 13:04 franciscojavierarceo

I've applied the formatting using make format-python

Apr 06 '25 11:04 predictorsSH

Hello, is there any updates?

Jun 25 '25 12:06 makSSMZ

No further updates from my side.

Jun 26 '25 05:06 predictorsSH

@predictorsSH Sorry, can you tell when the fix will be available? Or will the problem not be fixed at all?

Jun 26 '25 07:06 makSSMZ

@predictorsSH can you please rebase (and squash, if possible) ? Once CI passed, we can get it merged.

Jun 27 '25 04:06 ntkathole

Can you please tell me the approximate time when the fix will be? We are really looking forward to it. Thank you!

Jun 30 '25 14:06 makSSMZ