Tao
Tao
## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...
https://github.com/user-attachments/assets/b6da794c-a4f7-4a4f-9c0e-3f071a541609 Maybe this should be fixed as a frontend bug: When `no.4` approves, the frontend optimistic message shows `no further action required!`, but the correct backend data is `waiting for...
> @ntdiary Is this reproducible on the latest main? If yes, I think we should fix it as a separate issue. The reason I'm asking here, is if we don't...
> @ntdiary are you waiting on me or @nkdengineer to look at your latest message? @Beamanator, I’m waiting for the new sorting implementation, and to see if [this bug](https://github.com/Expensify/App/pull/52537#issuecomment-2504308501) should...
BTW, it would be great if we can add some unit tests for this feature, since we've recently started prioritizing unit test. :) slack conv: https://expensify.slack.com/archives/C01GTK53T8Q/p1733148961659549 https://expensify.slack.com/archives/C05LX9D6E07/p1733164389303049
> Do you both understand each other's setups or should you both lay out the setup (policy type, `autoReportingFrequency`, approval mode (basic vs advanced), members list / who approves to...
@Beamanator, this `employeeList`? For easier testing, my account name matches the email number. e.g., `no.1` corresponds to `[email protected]`. :) approval flow: submitter(`no.24`) -> `no.1` -> `no.2` -> `no.3` -> `no.4`...
> Right, in @ntdiary 's case at least, it's not a backend bug, it is expected for the `submitsTo` to approve (in advanced approval case) AFTER all of the rule...
BTW, @Beamanator, curious, can we have multiple tag approvers for 1 single expense? So far, I’ve only seen that a regular tag can have just one approver. Although we have...
> Ya thanks for getting us full circle 😂 I honestly do think this is something we need to fix in this issue - agreed we don’t want this to...