Tao

icon indicating an email [email protected]

Results 93 comments of Tao

clean up the deep link code

The code has been updated to fix issue #17391. The solution is to show the popup after the web transition is end.

clean up the deep link code

@marcaaron, thank you very much for the questions and suggestions! I think the reason why it still looks confused is that we need to call `this.openRouteInDesktopApp` method after fetching the...

clean up the deep link code

Personally, I think for this case, if we can get the `shortLivedAuthToken` from the response through an API (now we use `makeRequestWithSideEffects`), and then choose whether to show the popup...

clean up the deep link code

Hi, @tgolen, is there anything else we need to do? : )

clean up the deep link code

Hi, @tgolen, I resolved the conflicts again, not exactly sure how to get this PR merged, do we need a C+ to review or anything else? 🥲

clean up the deep link code

@0xmiroslav , thank you for the reminder, conflicts have been resolved. : )

clean up the deep link code

Hi, @0xmiroslav is there anything else I can do for this PR? : )

clean up the deep link code

https://github.com/Expensify/App/assets/8579651/1ddb56af-5ed9-4cd1-bd35-594a1b44469f https://youtu.be/Pu2LQw-d-U0 @0xmiroslav, interesting, it works for me. Could you temporarily print the value of deeplink in the `openRouteInDesktopApp` function? We can first check if it contains the `shortLivedAuthToken` parameter,...

clean up the deep link code

Wow, I haven't encountered this error before, not sure what the expected behavior is in this case. If `jsonCode` is not 200, do not show the popup window?

clean up the deep link code

> It's constantly reproducible to me right now. I even tried after logout and fresh login Eh, maybe we need help from the backend to check why this error occurred....