nt4f04uNd

Results 207 comments of nt4f04uNd

This would make the FlutterActivity to create its own engine which would break the plugin. I tried reproducing the bug with the example you provided, but it didn't happen. It...

Ok thanks. > This would make the FlutterActivity to create its own engine which would break the plugin. Actually, I misread what this was doing, sorry, it should work fine...

iOS doesn't support that https://apple.stackexchange.com/a/176543/387999

I tested, it works as expected > The equality method for MediaItem only checks the id field (based on assumptions that I've now forgotten) so it won't pick up changes...

We have a test written to catch changes like this. It's still a good point, thanks

I rewrote with the `CancelableOperation` from async, it should ensure each time new art is being fetched, the previous operation is cancelled

@ryanheise would you mind taking a look on this (and my other PRs)? No rush at all, take your time

When will you have a chance to look at my submissions? I would want to continue contributing to the plugin but I start feeling hesitant at this point, because there...

> If the operation is cancelled, is it really cancelled if onCancel doesn't do anything? Yes, this is how `CancelableOperation.then` implementation works, any chained `then`s are not called. > I...

I feel like the review of my code in this PR creates a lot of problems for you. Please don't hesitate to just take over this yourself, if you feel...