Nathaniel Starkman

Results 199 issues of Nathaniel Starkman

Flake8 and pycodestyle supports some config locations locations, none of which are `pyproject.toml`. As `setup.cfg` is slowly phased out in favor of `pyproject.toml`, these configurations have to move out of...

testing
installation
no-changelog-entry-needed

Signed-off-by: Nathaniel Starkman (@nstarman) ### Checklist for package maintainer(s) This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look...

time

Signed-off-by: Nathaniel Starkman (@nstarman) ### Checklist for package maintainer(s) This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look...

testing
wcs
installation
no-changelog-entry-needed
wcs.wcsapi

Signed-off-by: Nathaniel Starkman (@nstarman) ### Checklist for package maintainer(s) This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look...

installation
visualization
no-changelog-entry-needed
visualization.wcsaxes

Signed-off-by: Nathaniel Starkman (@nstarman) ### Checklist for package maintainer(s) This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look...

installation
no-changelog-entry-needed
timeseries

> Doesn't it make more sense to import setuptools before you import numpy for this case? __Originally posted by @pllim in https://github.com/astropy/astropy/pull/13699#discussion_r974285689__ The context is that `isort` treats all third-party...

Refactoring
needs-discussion
dev-automation

### Description ``__construct_mixin_classes`` is quite brittle. It would be better if each subpackage could register into ``__construct_mixin_classes``. To prevent weird import-order issues, maybe this could use entry points. ### Additional...

Feature Request
time
units
coordinates
Refactoring
utils.masked

Or at least use the maximum precision of the matrix dtype instead of the arbitrarily chosen 1e-15. https://github.com/astropy/astropy/blob/3912916dad56920514ba648be400a5f82add041a/astropy/coordinates/matrix_utilities.py#L137-L163

Feature Request
coordinates

### Description We have a lot of blanket ``# noqa`` (instead of e.g. ``# noqa: F401``) , which is bad practice. If we add the pre-commit hook https://github.com/pre-commit/pygrep-hooks, then no...

Feature Request
dev-automation

### Description What does it still do and can we remove it?

build
Refactoring
question