Nathaniel Starkman
Nathaniel Starkman
The gala function `get_transform_matrix` computes a transformation matrix using the Astropy `frame_transform_graph` machinery for static-or-dynamic matrix transforms. While Astropy does store the composite transformation in its cache for repeated calls,...
### Proposed new feature or change: It would be very useful to be able to type annotate that a ``dtype`` is structured. A runtime-checkable ``Protocol`` is insufficient to detect `names`...
Mypyc cannot compile if there's a singledispatch function defined outside the main namespace, for example in the body of a function or class. **To Reproduce** 1. Make a file with...
``isinstance(obj, ProtocolSubclass)`` only checks the the existence of ``ProtocolSubclass``'s methods on ``obj`` and not the type signature. To provide deeper checks, maybe ``isinstance`` could check attributes/methods on ``ProtocolSubclass`` that are...
### Description With `black` + `isort` + `pre-commit` I don't think `pep8speaks` does anything.
Signed-off-by: Nathaniel Starkman (@nstarman) ### Round-tripping 1) The redshift is not actually stored, even if passed to the Distance constructor. This means the distance is recomputed every time and only...
Fixes #12964 Maybe backport? Signed-off-by: Nathaniel Starkman (@nstarman) ### Checklist for package maintainer(s) This checklist is meant to remind the package maintainer(s) who will review this pull request of some...
Signed-off-by: Nathaniel Starkman (@nstarman) One more step on the roadmap to deprecating `setup.cfg`. Eventually `pytest` will support ``pyproject.toml`` (support is currently in beta), but until then I've moved the configuration...
Right now we use a small subset of flake8 in pre-commit. Given that pre-commit runs primarily on PR diffs, it seems fine to check for more problems. There are hundreds...
Signed-off-by: Nathaniel Starkman (@nstarman) Followup to #13703. ### Checklist for package maintainer(s) This checklist is meant to remind the package maintainer(s) who will review this pull request of some common...