Nathaniel Starkman
Nathaniel Starkman
@mhvk, I think that the ``() => ``, e.g. ``SkyOffsetFrame(ICRS) == SkyOffsetICRS`` is a bit too magical. Instantiating a class should return an instance, not another class. I'm thinking instead,...
@JefftheCloudDog the issue appears to be that the HTML table writer doesn't work with units. Here's how I found the relevant documentation, which includes all the various things the HTML...
@JefftheCloudDog the CI isn't fully running because the Code Style Check runs first and it's currently failing. There's usually an easy fix and that's to run ``tox -e codestyle`` from...
@JefftheCloudDog, a good observation. I just did some testing and it doesn't look like the table -> HTML writer keeps any of a table's metadata! Fixing this is out of...
@JefftheCloudDog, it looks like the CI didn't start. Can you rebase and re-push? That should get it going. Thanks!
@JefftheCloudDog If you click on the former it will take you to the full traceback, which is very useful for diagnosing problems. The changelog error is because this PR does...
@JefftheCloudDog, please rebase on the main branch instead of merging.
@JefftheCloudDog thanks for rebasing and cleaning up some of the commits. R.e. connecting to ``ReadWriteTestMixin``. This is how we test that the HTML writer works with each Cosmology subclass (e.g....
@JefftheCloudDog, the issue is that the HTML I/O requires a third party library that isn't always included in the CI. We can just hack on another boolean in the CI....
> "Correcting the Table check is important since `cls` allows for any Table subclass." > > Do you mean adding an early exit/warning if cls is not a QTable? See...