Nathaniel Starkman

Results 126 comments of Nathaniel Starkman

> Or should the value be something else for testing purposes? We definitely want to provide to the user the correct values, so those will have to be tested. >...

> There seems to be an issue with test_readwrite_html_mutlirow. `TypeError: only dimensionless scalar quantities can be converted to Python scalars` I'm not quite sure what this means. The other new...

I might come back to this later, but for now, it doesn't seem like Astropy requires this PR.

> @nstarman, do you know how to solve these Sphinx warnings? If not I might have to get rid of the typing annotations to get this to pass. Sorry, I...

Agreed. I didn't realize how poorly typing is handled in RTD, esp because it's interpreted as a string by static type checkers.

> NEP 42 allows one to place the unit on the dtype, which I think will mean a considerable simplification of the system. Agreed. > It should be quite possible...

I'll be happy to squash these bugs, just as soon as there's a conda python 3.11 version available, (even a release candidate) :)

@WilliamJamieson, is this PR still valid? or does asdf-astropy implement all this?

@eerovaher. This is a cool idea. In #12983 we are refactoring the ``format`` specifiers into a mixin class so that ``cosmology.Parameter`` can use it as well. Since ``cosmology.Parameter`` has a...

> `coordinates.Angle` is a subclass of `Quantity`, so it also benefits from this update. Should there be a second change log entry under the `coordinates` section? I don't think it's...