Nahum Shalman

Results 90 comments of Nahum Shalman

Per the discussion in https://go.dev/cl/465015 I think the next step is to make the tests handle the syscalls returning EINTR more gracefully. The occurrence reported by the bot isn't the...

My current sketch (needs some light commenting, and to be used in all the tests currently calling GetOne...): ```diff diff --git a/unix/syscall_solaris_test.go b/unix/syscall_solaris_test.go index 6c2b906..d79e9fb 100644 --- a/unix/syscall_solaris_test.go +++ b/unix/syscall_solaris_test.go...

Looks like the improved error message works. Good reminder for me to finish up https://go.dev/cl/465055

> It sounds like you potentially identified the patch that may be causing the problem upstream, so I'll continue monitoring if there are any changes. We can always generate a...

Revert of that commit (specifically as performed in https://github.com/nshalman/ipxe/commit/841d1cda0072e4259d09e36ac4df1fc0914cdb7a ) does seem to alleviate the issue in my initial testing.

The tested revert was specifically fbc3b4a104698658202c2a83217ca8722453bf49 https://github.com/ipxe/ipxe/compare/master...nshalman:ipxe:fbc3b4a104698658202c2a83217ca8722453bf49

I may not have tested on the latest master. Thank you for the pointer.

My test fails on the latest commit of master (98dd25a3bb2d3aafa71f088cbabf89418a783132) ``` http://147.28.150.231:8000/ipxe.efi... ok iPXE initialising devices...ok iPXE 1.0.0+ -- Open Source Network Boot Firmware -- https://ipxe.org Features: DNS HTTP HTTPS...

Just confirming that additional testing confirms that Mellanox CX4 cards are having trouble once booted into the latest commit of iPXe (98dd25a3bb2d3aafa71f088cbabf89418a783132) but the problems go away if I apply...

@Smithx10 can you try the workaround suggested by @Cornelicorn and report back if it helped as it's a much less invasive workaround to tweak a define than backing the code...