Nahum Shalman

Results 66 comments of Nahum Shalman

Reproduction is hard and inconsistent in how long it takes. Here's a test case that can eventually trigger it at least sometimes: ```diff diff --git a/unix/syscall_solaris_test.go b/unix/syscall_solaris_test.go index c2b28be..d597355 100644...

For posterity I'm updating this comment with the version of the test that I ended up using to further debug this issue and to test the fix. ```golang func TestEventPortMemoryStress(t...

Yeah... If I run that test with `GOGC=off` it never panics. Either I'm not creating the references the garbage collector needs so that it understands what I'm trying to do...

> FWIW, at https://cs.opensource.google/go/x/sys/+/master:unix/syscall_solaris.go;l=954 `uintptr(unsafe.Pointer(fCookie.fobj)) == uintptr(peInt.Object)` is a violation of the `unsafe.Pointer` [requirements](https://pkg.go.dev/unsafe#Pointer). It is not safe to store a Go pointer as uintptr or uint64. > > That...

Well, I tried simplifying things and while that makes all the code way easier to read, and the tests pass with `GOGC=off`, the tests still fail when the garbage collector...

I've pushed up a commit with some heavy-handed debugging to answer those questions at https://github.com/nshalman/sys/commit/1bbdf4655b7477087d48f28f5cf216d4a46861de Again, `GOGC=off go test` completes with no issues. `go test` will now pretty reliably trigger...

Had a brief discussion with @rmustacc on IRC who helped me come up with some dtrace to look a little closer at what's going on from the OS side. ```dtrace...

> This is clearly my own fault, but I am not smart enough (yet?) to figure out where my bug is. Oh sweet summer child... I'm now convinced that this...

I've updated the description at the top of this issue to include some helpful text to anyone directed here from the error message proposed in https://go.dev/cl/422099

I've tweaked the language in the description one more time now that golang/sys@c680a09 has landed. Thank you to everyone!