Nahum Shalman

Results 70 comments of Nahum Shalman

Sorry it's been so long. All necessary unsafe things have been moved to x/sys/unix. I imagine there's still more work to be done, but I think this is another moment...

Still some more cleanup to do, but we're getting very very close. Not marking for review yet because there are still some unaddressed comments I should take care of.

> Can you test this all and remove the XXX comments before I do a full review? Yes. Thank you for your patience with me. > If you have questions...

> > Also, a question about style. go fmt seems to have opinions about things like build tags being at the top of the file and which lines to put...

I haven't forgotten about this. @gco reached out to me to let me know that with a bit of copying functions around and s/illumos/solaris it was possible to get this...

Via @jclulow (https://github.com/jclulow/wireguard-go-illumos-wip/blame/jclulow/README.md#L15)

I've added a commit to #72 that moves the cleanup logic to [`create-image.sh`](https://github.com/tumblr/genesis/pull/72/files#diff-2d00666fa1a5642896562eb90ad49899R81) (and calls `losetup` directly from `awk`, removing the need for `xargs` as well)

> Thinking we may need to rollback the changes for now -- so we can take our time on giving it another try. I support that.

Is there a reason to only run this test on Windows?

I don't think this test catches the corresponding error. I tried pushing a branch with the test but not the fix and the tests still pass: https://github.com/nshalman/fsnotify/actions/runs/1709124231 I think we...