Nick Schonning

Results 465 comments of Nick Schonning

Sample annotation after enabling one of the rules ![image](https://user-images.githubusercontent.com/1297909/218243632-e1d43262-ca6e-421a-a1bb-922cd9ef56ae.png)

@Gargron do you prefer the cleanup split off from the main CI setup?

Added the additional glob so Prettier gets called on the CSS/SCSS files to match the changes in https://github.com/mastodon/mastodon/pull/23558

Updated now that ESLint is checking JSX files, and moved the prettier run for all files, since things that shouldn't get touched are covered by the `.prettierignore` now. I could...

@Gargron are you interested in this one, or should I close it?

Didn't think that would be an issue since NPX ships with Node, but I've submitted https://github.com/mastodon/mastodon/pull/24287 to swap it to Yarn

I've undone all the line ending changes to make this easier to land. This is now just a run of `bundle exec rubocop -x --server --except Layout/LineLength`

The EOL of 14 is April 30th https://github.com/nodejs/Release#release-schedule. Doesn't have to be now, but it's getting close

@ineffyble I tried regenerating the lockfile in https://github.com/mastodon/mastodon/actions/runs/3615835806/jobs/6093238472, but rolled it off, and it's back to a network issue on the install

@ineffyble just checking that you're asking that the other PR gets landed, not merged into this PR. I think the separate approach over there makes sense, and is a similar...