Nick Schonning

@mjankowski closing in favour of https://github.com/mastodon/mastodon/pull/25991, but I'm not sure if that one should also unignore the Renovate, or wait till 1.4.4 is fixed

No, I think before it worked, but it seems like it's failing after I rebased, so I think your next hop makes more sense

The comment on my test PR on my repo didn't have the right comment since it didn't have a baseline, but you can see the coverage report for the branch...

Merged in the ruby coverage. You can see the test PR over here https://github.com/nschonni/mastodon/pull/117 with the details on https://app.codecov.io/gh/mastodon/mastodon/tree/jest-coverage Looks like @mjankowski has added another 10% of the ruby since...

@Gargron @ClearlyClaire do you prefer not having the bot comment, and just having the status check? I think that might be configurable if the app is installed, with the comment...

Looks like the preview URL above isn't working now without the GitHub App being installed on the repo ``` [2023-05-22T18:55:46.073Z] ['error'] There was an error running the uploader: Error uploading...

There is some JS testing already like https://github.com/mastodon/mastodon/tree/main/app/javascript/mastodon/components/__tests__ E2E testing would be good, but unit testing covers other assumptions

Should I delete the JS/TS CI stuff and the extra `jest:coverage` target? Should I add a `codecov.yml` to track an of those threshold changes https://docs.codecov.com/docs/codecov-yaml

Struggling with the Yarn 4 stuff, but I got it rebased without the JS parts

I updated the Dockerfile to match, and there are 2 PRs that landed around the same time looking at Dependabot to keep those versions updated. Those PRs would likely still...