Niklas Schandry
Niklas Schandry
I think this is now complete. charliecloudBuilder now understands additional parameters: `registry`: see earlier comments, adds support for registry as used by nf-core `writeFake`: make use of `--write-fake` `useSquash`: use...
Is there anything I should add to this PR? @pditommaso
Thanks for running the tests @bentsherman . I do not know why `test_docs` fails. I don't see how the step that fails (https://github.com/nextflow-io/nextflow/actions/runs/7887508884/job/21614649213#step:5:465) would be related to the changes I...
Since this PR has now been open for more than a month, I am wondering if there is anything I should add or change to facilitate merging?
These failing tests appear to come from `plugins:nf-google`, I don't think they are related to the changes to the charliecloud driver, but if they are I would probably need some...
I have merged recent master into this, maybe that solves the failing tests..
Do you think it would be worth opening a new pull request from a new branch, including only the changes for charliecloud? I am not sure if one of the...
I have created a new branch from current master. If you think it makes sense to try with a new PR I can open a new one and close this....
I realized that this issue is tied to $CH_IMAGE_STORAGE. ch-run refuses to allow images from its storage directory by path, and accepts these only by name. One possible workaround is...
Since charliecloud will soon provide `--write-fake`, are there plans to add support for this to nextflow? I guess it would require some checks for the charliecloud version used, or removing...