Nicolas Savoire
Nicolas Savoire
We should also update the requirements: ``` Supported operating systems : Linux kernel v4.17+, libc 2.18+ ``` to something like: ``` Supported operating systems : Linux kernel v4.17+, glibc 2.23+...
`Py_INCREF(cell)` [here](https://github.com/mkleehammer/pyodbc/blob/master/src/params.cpp#L349) looks suspicious since we are storing `encoded` not `cell` in `pParam`: ```c++ // DAE DAEParam *pParam = (DAEParam*)*outbuf; Py_INCREF(cell); pParam->cell = encoded.Detach(); ``` This looks like a copy...
Some profiler tests are still failing on Windows, probably because timeline is not available here.
Symbolization from /proc/%pid%/maps mostly works, but is not yet well integrated with the rest of the code. Issues/ToDo: - Remove TracedBinary object, it looks like it is not needed anymore...
> ``` > [ RUN ] allocation_tracker.start_stop > /go/src/github.com/DataDog/apm-reliability/ddprof-build/ddprof/test/allocation_tracker-ut.cc:141: Failure > Expected: (sample->dyn_size_stack) < (hdr->size - sizeof_allocation_event(0)), actual: 18088 vs 18088 > [ FAILED ] allocation_tracker.start_stop (323 ms) > ```...