Nico Ritschel

> * we should think very carefully about whether checking the box of the parent node (eg Explanation) should check off/on all the children rubric items. I can now see...

> I will do a proper review when I have more time, but I'm a bit concern about accessibility in this context. In particular, a slight indentation is the only...

Regarding accessibility: it seems like there's an established way to handle this (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tree_role) that shouldn't be too hard to implement. I'll look into this!

@jonatanschroeder I've made some updates and the rubrics now both have the appropriate ARIA attributes and (except for the settings panel, which is still a table) also use a proper...

I've noticed that the display of format error messages isn't ideal if there's more than one separate pl-file-upload on the same page. I'm looking into this, although it is mostly...

Fortunately I did think of these issues before implementing, and conveniently I had already added a “delete” button in the student UI before this change. Basically, students can replace files...

It’s not like I haven’t considered fnmatch when I started writing this PR, but there are two problems: 1. Avoiding regex altogether would be possible if this element was just...

> I played around with `fnmatch` briefly, and if you trim the trailing `\Z`, it should be compatible with javascript. > > ```python > print(translate('*.txt').rstrip(r'\Z')) > ``` > > ```js...

I've addressed all of @reteps review comments, but I'm not sure what to do about the type error with `json.loads`. I think this is already broken in the existing version...

Sorry for taking a while to get to this. I've worked through all the new nits.