Nicholas Reinicke

Results 27 comments of Nicholas Reinicke

Actually, it looks the the outputs are actually getting written to the default directory (which is an empty path `""`, defaulting to the location where the command is run) but...

Here is where the strings get loaded from the input configurations and a good candidate for validating them: https://github.com/NREL/hive/blob/2220709fc90df31919bd10f313e5b89be9372d95/nrel/hive/config/dispatcher_config.py#L46 These strings should be converted into a [`VehicleStateType`](https://github.com/NREL/hive/blob/2220709fc90df31919bd10f313e5b89be9372d95/nrel/hive/state/vehicle_state/vehicle_state_type.py#L4). It probably makes...

yeah good call; I wonder if this could even become automated by moving this log over to the documentation and then running the denver demo whenever we build the docs.

Considering that version 4.0 isn't yet stable we should probably hold off on including it as a required dependency. Maybe we defer this until 4.0 is the de-facto version?

One idea is that we could at least write each report type to a dedicated file (rather than a single log file for all states and all events). In that...

> i'd like to couple with this a performance benchmark, to make sure the overhead of switching to ResultE is insignificant. yes, that's a great point; this would be great...

I just did a quick test of this, comparing a method that returns the old `ErrorOr` type to a function that returns the `ResultE` type (and unwraps the result). The...

Another overlapping issue: #84

We should probably merge this with #84 and possibly break out into sub issues