Nick Cameron

Results 260 comments of Nick Cameron

I did some research on enforcing the style guide mechanically, and I am a bit disappointed with what we can expect Clippy or Rustfmt to do. Some things are already...

cc https://github.com/tikv/tikv/pull/9767

> Do you have some ideas about how we can improve it? Could use newtypes instead of type aliases? (That would have other advantages too) Otherwise, you could link to...

It would be nice to have slightly more finegrained control with this option, in particular, I would like to allow items which fit on a single line to have a...

The strategy here will be to get the text for the macro, replace every `$foo` in the body of the macro with a string of the same length, e.g., `xfoo`....

re aside: no. I'm keen to do some refactoring-ish changes, I'm not sure where to draw the line though.

> Is there anything new on this? No update, sorry. This is a 'some day' feature tbh.

@estk that would depend on how invasive the patch is. If it can be done without too much change, then it would be good to have, if it requires a...

> Can the local mirror (export TIUP_MIRRORS=/path/to/local) resolve this issue? Maybe. It depends on the specific ways that we design TiUp, e.g., if there is a manifest in the local...

> Do you mean why we need offline or other else? I meant why we'd want a reference to an online repo from a local repo