Nick Cameron
Nick Cameron
> Do you think extracting only the tikv related protos and making them a dependency here would be a good first step to enable this? Maybe a tikv-api crate? I...
I don't understand either of those points, sorry. > These protos were too big for Raft (which is relatively small) to depend on Why is size an issue? > No,...
> Hmm, compiling kvproto takes a long time. This is true of a full build (1m 16s for me), but building kvproto itself only takes 7s. Given that any deps...
> Sorry, it should be standalone. 🤣 That makes more sense, thanks! However, I'm still a bit unclear *why* Raft is a standalone library in this sense. If it is...
> Because kvproto uses the struct of raft protocol directly, and due to the limited of protobuf compiler, we need to reexport raft proto interface to make the generated code...
Proposal: * Move the Raft protos into a RaftProto repo * Raft depends on RaftProto * KvProto depends on RaftProto, not Raft * Move the code for generating protos in...
> It sounds good to me. But I have also been thinking about removing raft dependency from kvproto, so that raft is free to change its protocols, or even no...
Cool, thanks for looking at the protocols!
Maybe need to `git submodule update --recursive --init`?
Yeah, I think so, though not very high priorty