Nolan Brubaker comments

Results 213 comments of


                                            Nolan Brubaker

🌱 Migrate gc to aws sdk v2

Merging another PR unfortunately introduced some conflicts on this one. Also, the copyright for brand new files should be the current year.

🌱 Migrate gc to aws sdk v2

Looking at the last few failures in this PR, it looks like they're not consistently the same thing, so I'm thinking they're unrelated to these changes. /test pull-cluster-api-provider-aws-e2e

🌱 Migrate gc to aws sdk v2

Looks like there are some merge conflicts again :(

:seedling: Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 in /hack/tools

/retest

:seedling: Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0

/retest

:sparkles: Add support to specify PartitionNumber of placement group

/lgtm

Add nrb

Double checked, the linked PRs appear to be merged and it looks like I have appropriate access, so closing.

Should InternalDNS names be lower-cased

I think this causes issues downstream of CAPA, so that even if our systems are working, anything else that relies on hostnames (for example, certificates) might fail if the casing...

:sparkles: Addons: Add functionality for resolveConflicts: PRESERVE

/ok-to-test

:sparkles: Addons: Add functionality for resolveConflicts: PRESERVE

Thanks for this! Overall, this looks good to me. The tests are currently failing because `make generate` needs to be run and the results committed, and it looks like the...