Nolan Brubaker
Nolan Brubaker
/assign /triage accepted
@hackeramitkumar Are you still able to continue with this PR? Also, could you add `Closes: #3453` to the description? [You mentioned](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3453#issuecomment-1528655350) that this change would fix those issues, as well.
@dependabot recreate
> This change is causing [pull-cluster-api-provider-azure-apidiff](https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5666/pull-cluster-api-provider-azure-apidiff/1948057193597112320) to fail. For what it's worth, that's not a required check. It's up to maintainers of a given project, but if the api diff...
> I decided to move PrivateDNSZone from [NetworkClassSpec](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/api/v1beta1/types_class.go#L457) to [NetworkSpec](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/api/v1beta1/types.go#L92) because within the NetworkClassSpec, the properties may be shared across multiple clusters. While I'm not very well versed in CAPZ...
CI's fixed. /unhold
/test pull-cluster-api-provider-aws-test Failed due to CI account limits, not this code.
/triage accepted
I've captured the Makefile changes that I've made here: https://github.com/nrb/cluster-api-provider-aws/commit/25d57a852edab1f2e42cad819d8acb27a03dd457 Copying the commit description just in case it gets overridden: > NOTE: This commit still needs work. Generated files were...