Nilay Pochhi comments

Results 9 comments of


                                            Nilay Pochhi

FileNotFoundError while running the code

@JafferWilson Where should we keep the downloaded data?

Added is present check to traversals

Okay, understood. So, I'll have to use `unordered_set` during preorder and postorder traversals.

Added is present check to traversals

@isuruf Will the above mentioned data structure be sufficient for this purpose?

Added is present check to traversals

Can you please suggest me an approach regarding other Visitors?

Visitors should check if a subexpression was visited before

Should we use `unordered_set` to store the visited subexpressions. If so, should I typedef it in `dict.h`? Also, should I apply this is present check to entire `Visitor` class or...

Visitors should check if a subexpression was visited before

I think we can close this issue..

Visitors should check if a subexpression was visited before

Okay, I'll do the required changes in a new PR.

‘eglInitialize() failed’

Hi, I'm not sure if this solves the issue but I faced the same issue earlier and I solved it by copying `nvdiffrec/docker/10_nvidia.json` to `/usr/share/glvnd/egl_vendor.d`.

Rename `read_pickle_distributed/to_pickle_distributed` to ` read_pickle_glob/to_pickle_glob`

Hi 👋, I'd like to work on this simple issue if it's alright with you.