nperraud

Results 65 comments of nperraud

@reivilo3 Thank you very much. For now I need to get the test starting again before possibly doing a merge. I am not sure what happened for the lambda. I...

For me the algorithm look correct and the test case added seems to cover most of it. So I will give it a pass. I agree that it is better...

The problem probably comes from the fact that the lambda parameter was replaced by mu. I would need to speed a bit of time to fix it and I don't...

Hi @jacquesdurden , I think this parameter is inherited from the class `norm`. See: https://github.com/epfl-lts2/pyunlocbox/blob/66181218a3268444983233720f0dc10392c15d5a/pyunlocbox/functions.py#L405

Well I call this a bug. Thanks for spotting and reporting it.

yes, we have to replace T by gamma where gamma = self.lambda_ * T. this also require to write some tests to be sure that everything is correct. I am...

@ThomasA if you want to finish this, I would be happy to help.

Is this based on some publications?

I think swichting to black is a good idea.

Do you want me to give a shot at this? I would go with the following steps: 1. Go back one commit 2. Rebase on master 3. Fix make lint...