nperraud

Results 65 comments of nperraud

Another problem that I see is that the installation of the library for approximate nn is not well documented...

I have just added the function I coded to this branch to get the nearest neighbor search out of the Knn graph. The Knn graph function still needs to be...

I tried, but failed. They work on my machine but the seed is different. I have to think about how to do it... Maybe you can help me. Let us...

Tests are passing... The coverage is reduced (probably less raise Error check...) but I think it will increase again once the functions in _nearest_neighboors are cleaned. I wil do that...

Ok Should be ready for the merge...

@mdeff Everything is done. For me, it can be merged to master.

I suggest the following: - `NearestNeighbors` instead of `NNGraph` - I find all possibilities bad for the variable `kernel_width` because it is linked to the gaussian function. So I am...

Seeing all your proposition, I believe `scale` is the best option. It is rescaling or renormalisation, but I would prefer not to use something like `norm` because it is confusing.

Thanks for reporting this. @mdeff do you know why this definition was used? I remember we had a big discussion about the definition when working on a student project together...

The Chebyshef implementation of the gspbox was taken from the code of the spectral wavelet paper from 2012. I do not know why this two is there and it might...