Michael Howell
Michael Howell
It's also not clear what "making the button smaller" would actually mean. * Shrinking the icon won't help, because it's the text that's actually the problem. * How much smaller...
@GuillaumeGomez Could you put together a mock-up of what you mean?
I don't really like fit-content, since it causes layout shift when you toggle the summary. Watch the settings button. https://github.com/user-attachments/assets/41a761c3-b925-412d-8e34-d830fe5a8846 I'm also iffy about 14px text, but that might be...
I still don't like using text that's smaller than the natural size, and, even with two buttons it looks pretty bad. How does this preview screenshot look, for a way...
Okay, I've rebased onto 0.12.
For simplicity's sake, I'm going to use the term ***item lists*** to refer to numbered and bulleted lists, as opposed to "definition lists." > Also, I wonder if the number...
- okay, I've fixed the fmt errors - as for this being a breaking change, I'm pretty sure the new generic param is a breaking change anyway, so it's kind...
I like the idea of combining the traits. I don't like the "Note, Tip, Important, Warning, Caution, Custom(CowStr)" design. If making it generic isn't acceptable, then it seems simpler to...
Because the set of supported tags is fixed, we don't actually have to allocate anything. The `'static` lifetime is a subtype of `'input`. And we can define the return value...
It looks like you’ve mostly just changed import lines. If it’s helpful, then this change seems okay to me.