Michael Howell

Results 244 comments of Michael Howell

#1652 seems to perform a lot better than the earlier syntect benchmarks.

The color schemes aren't actually the same. Is that a bug? Old version: ![image](https://user-images.githubusercontent.com/1593513/133864984-c4382873-b497-4ccf-8016-08338b181ee3.png) New version: ![image](https://user-images.githubusercontent.com/1593513/133864956-8034c9a8-3dc4-4053-9675-eb70f8044ffe.png)

@ThePuzzlemaker I've tweaked the themes to make them closer to before, and also wrote the documentation for generating these themes from their tmTheme source files.

@ThePuzzlemaker where did you get the Handlebars syntax from? Whatever source it came from should really be documented.

If you'd like any help, please @ me and I'll look through your revised PR.

Okay, first of all, `testindex_fixture.json` is generated automatically. If there's a conflict, you're expected to re-generated it with this (somewhat hacky) tool: https://github.com/rust-lang/mdBook/blob/94b922d27aea47183ebf270e2f6f32561d960852/tests/rendered_output.rs#L797-L800 Beyond that, the way you've rebased it...

The code that looks like the culprit is here: https://github.com/jgm/commonmark-hs/blob/1875e9aac4bba290e191a0f692173c8c40316b55/commonmark/src/Commonmark/Inlines.hs#L840-L843 In this case, the end paren is in the middle of a "parsed code" chunk, which gets split into the...

The three options that come to my mind are: 1. You can't have unescaped `` ` `` in link destinations. This is the easiest, and doesn't match cmark.c. 2. Re-parsing...

I implemented option 2 in https://github.com/jgm/commonmark-hs/pull/137, but this implementation has potentially quadratic behavior. The trouble with option 3 is that the extensions also need redone, because `$math$` is just as...