Michael Howell

Results 244 comments of Michael Howell

This probably needs re-thought through to match up with https://github.com/rust-lang/rust/pull/110800. I'll start FCP if that's done, since this change otherwise looks good.

> Another thing to note is that you will be able to add attributes to generated codeblocks with this syntax: custom,{name=something}, meaning that in your case, name here would not...

So, if we're essentially on board with calling it `name`, I'll start the FCP on that one. @rfcbot fcp merge

Or put it inside the braces. I just didn’t catch that.

Wait a minute. It reverted back to commas? @rfcbot concern interoperability We seem to be going in circles. The original commit, https://github.com/rust-lang/rfcs/pull/3311/commits/7641de1ba91ab75369c4b0c616032e84959165df, from 2022, used the syntax `rust,name=foo`. I objected...

> Commas are the only character to separate annotations currently. That doesn't seem to be true. https://github.com/rust-lang/rust/blob/b92758a9aef1cef7b79e2b72c3d8ba113e547f89/src/librustdoc/html/markdown/tests.rs#L286

Can't we do this with GitHub status notifications? Like Travis CI does?

That’s fine. mdBook is still 0.4, so it can still release a 0.5 some time. Also, I should probably document the `fa` handlebars helper in the manual. Since this is...

@ehuss Docs and inline fixup for fontawesome icons have been added to the HTML renderer, so that books using font-awesome will still be able to do so.

@ehuss Now that the fixups are included to allow books that already use font-awesome to continue doing so, and the documentation is written, is there anything else preventing this from...