Branton Horsley

Results 7 comments of Branton Horsley

Sorry, a vanilla diff may have not been the best choice I added a check for 'structuredText[startLine]' being true that encapsulates: https://github.com/gotwarlost/istanbul/blob/v0.3.15/lib/report/html.js#L200 to https://github.com/gotwarlost/istanbul/blob/v0.3.15/lib/report/html.js#L209 and https://github.com/gotwarlost/istanbul/blob/v0.3.15/lib/report/html.js#L231 to https://github.com/gotwarlost/istanbul/blob/v0.3.15/lib/report/html.js#L240 to cause...

TWO different projects' collaborators responding in 2 hours? Well now I feel obligated to better reproduce the issue. Yes, 0.3.15 (in both browserify-istanbul and karma-coverage). ``` cat node_modules/*/node_modules/istanbul/package.json | grep...

Switched Istanbul to 0.3.14: https://github.com/notnarb/karma-coverage-issue-157/tree/istanbul-0.3.14 got a different issue: ``` DEBUG [coverage]: Writing coverage to /home/notnarb/Workspace/karma-coverage-157/coverages/Firefox 38.0.0 (Ubuntu 0.0.0) ERROR [coverage]: [TypeError: Cannot set property 'covered' of undefined] TypeError: Cannot...

Just tried that ``` ~/Workspace/karma-coverage-157$ karma start LOG: 'a' LOG: 'b' Firefox 38.0.0 (Ubuntu 0.0.0) LOG: 'a' Firefox 38.0.0 (Ubuntu 0.0.0) LOG: 'b' Chromium 43.0.2357 (Ubuntu 0.0.0): Executed 2 of...

Per that thread (emphasis mine): > In general we don't guarantee that the checksums of zip downloads will stay the same, *they do for downloads of releases though.* Given this...

Worked with @ahumesky to get to the bottom of what might be going on right now (and a huge thank you to him for helping me with this) As of...

Using one of the examples from that Slack thread I can see that it's not *only* http/2 causing the issue as one of the examples there does produce differing files...