Steve Myers
Steve Myers
I renamed and repurposed this issue to update to 0.22.0, fixed by #118.
Overall looks good! I made a few comments above. Also you need to run `cargo clippy` and fix what ever clippy tells you to.
On the MSRV question BDK is bumping up to 1.56.0. * https://github.com/bitcoindevkit/bdk/pull/596. Also the focus for the next `bdk` release 0.19.0 is TP support so also updating `bitcoin` to 0.28...
I think this will be fixed by #99 so I assigned it to you @rajarshimaitra to confirm. Thanks!
Moved this one to bdk-cli 0.7.0 since the updated version of `bitcoind` 0.27.0 isn't released yet.
I'm going to merge #89 and #71 for 0.5.0 and then I think we should release it. Can we move this issue to next milestone 0.6.0?
@rajarshimaitra I added a commit with some small grammar and punctuation changes. For the punctuation I primarily added periods to the end of lines in the rust docs, which is...
Good idea, rather than complicating the `broadcast` command with the extra options `finalize` has I'd prefer to give a nicer error if someone tries to broadcast a non-finalized psbt. ```shell...
Do the changes in https://github.com/bitcoindevkit/bdk/pull/621 solve your issue if we bring that into bdk-cli?
Yes my thinking is for the `sign` command to always `finalize` (if possible), and then add a `--no-finalize` for those who don't want to finalize for some reason. The result...