bdk-cli icon indicating copy to clipboard operation
bdk-cli copied to clipboard

Add add_data enables op_return for bdk-cli

Open logosstone opened this issue 3 years ago • 2 comments

Description

This enables users to send an arbitrary string message through a txn-output. The maximum size of this string-literal can be length of 80-bytes.

Notes to the reviewers

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I followed the contribution guidelines
  • [x] I ran cargo fmt and cargo clippy before committing

New Features:

  • [x] I've added tests for the new feature
  • [x] I've added docs for the new feature
  • [x] I've updated CHANGELOG.md

Bugfixes:

  • [ ] This pull request breaks the existing API
  • [ ] I've added tests to reproduce the issue which are now passing
  • [ ] I'm linking the issue being fixed by this PR

logosstone avatar Jun 28 '22 21:06 logosstone

Overall looks good! I made a few comments above. Also you need to run cargo clippy and fix what ever clippy tells you to.

notmandatory avatar Jun 29 '22 01:06 notmandatory

Overall looks good! I made a few comments above. Also you need to run cargo clippy and fix what ever clippy tells you to.

All changes have been updated, everything looks good to go! Thank you for testing @notmandatory . 🚀

logosstone avatar Jun 29 '22 03:06 logosstone

Rebased on the latest master ready for final review please.

logosstone avatar Sep 21 '22 16:09 logosstone