Manuel Gatti comments

Results 13 comments of


                                            Manuel Gatti

Better names for methods

get_utxos seems in fact getting utxos

Upgrade to `rust-bitcoin` 0.31.0

Needs to stay in 1.0.0 milestone in order to not block LDK, but we need to check also other dependencies It makes sense to upgrade to rust 0.31.0 for beta...

Rename electrum's sync/scan

Priority to be discussed further

Backwards compatibility of `bdk::ChangeSet` data structure

Lib team call: It changes the API so we should include it before cutting off for beta release

timestamp timelocks are not satisfied

Need a check to see if it remains in alpha @notmandatory

Inconsistent checking of RBF rules

We discussed it in the call and decided to close this issue. Please comment if you think it should be re-opened

ci: move to Nix (simpler, easy to maintain version)

@storopoli does this PR substitute #1257? Shall we close that or do we need to leave it open?

The Wallet.is_mine() function should return K

@notmandatory great, thanks for letting me know!

Wallet::get_descriptor_for_keychain should return an Option

We are going to make it mandatory to have descriptors for both keychains

Wallet's persistence should have a fixed "header" section

During today's discussion in the Lib Team Call, we were assuming that this issue requires breaking changes and so that it could be required for alpha.3. What do you think...