Nicolás Ojeda Bär

Windows binary release wrongly versioned

7

The binary release for Windows does not show the right version, eg for 0.21.0 I get: ``` $ ./ocamlformat.exe --version 0.21.0-4-gddca4a3-dirty ``` This makes it inconvenient to use with `.ocamlformat`...

`field-space=tight-decl` should apply to signature items as well

1

The option `field-space=tight-decl` should also apply to signature items, which are very similar to record fields, eg: ``` val foo: ty ``` instead of ``` val foo : ty ```...

The following term gets formatted with an extra trailing space after the last `;` when using `space-around-records=false` (and no other options): ```ocaml type default_local_volatility_calibration_fun = { chart_chooser : < as_unit_control...

Manual missing

9

`ppxlib` is missing a manual. Right now the only "doc" available is existing code or the various `.mli` files. A manual is necessary for a piece of the ecosystem as...

Weird behaviour of `-o` when compiling C files

6

(Discussed in #10610) In the current `trunk`: - `ocamlc -o foo a.c` ---> `gcc -o a.o -c a.c` - `ocamlc -o foo -c a.c` ---> `gcc -o a.o -c a.c`...

I synchronized with 4.14. This is untested, but the changes were pretty minor, mostly adaptations to API changes upstream. One issue that needs discussion is whether we want to keep...

What to do for `ftruncate`?

2

Is this function missing from `eio`, or is one supposed to use the one in the `unix` library (via `eio_unix`)?

The `result` type was introduced in 4.03, so the dependency on the `result` package can be removed.

server socket does not get EOF when closing client socket without sending any data

2

Hello, As in the subject, there seems to be a bug in `libutp`: if a connection is opened between a client and a server and the client closes the connection...

Try fix for #92

1

We need to process the ST_FIN packet even if the connection has not been fully established yet.